-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECDSA
: Use unchecked arithmetic for the tryRecover
function
#4301
Conversation
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
🦋 Changeset detectedLatest commit: 08b10b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pcaversaccio
This PR adds the usage of unchecked arithmetic for the
tryRecover
function that receives ther
andvs
short-signature fields separately. The addition can't overflow (in my understanding) by design since the shift operation results in 0 or 1.PR Checklist
npx changeset add
)